zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #453: ZOOKEEPER-2845: Apply commit log when restarting serve...
Date Tue, 13 Feb 2018 14:39:39 GMT
Github user anmolnar commented on the issue:

    @revans2 Your latest change looks good to me and a bit safer than the previous one. Would
you please consider adding some unit tests to validate the functionality?
    What do you think of porting testTxnAheadSnapInRetainDB() test from your codebase?
    Maybe I can help making it not flaky, if you think it correctly verifies the original


View raw message