zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #451: ZOOKEEPER-2184: Zookeeper Client should re-reso...
Date Tue, 06 Feb 2018 23:27:21 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/451#discussion_r166476047
  
    --- Diff: src/java/test/org/apache/zookeeper/test/ReadOnlyModeTest.java ---
    @@ -239,13 +243,13 @@ public void testSessionEstablishment() throws Exception {
         public void testSeekForRwServer() throws Exception {
     
             // setup the logger to capture all logs
    -        Layout layout = Logger.getRootLogger().getAppender("CONSOLE")
    +        Layout layout = org.apache.log4j.Logger.getRootLogger().getAppender("CONSOLE")
    --- End diff --
    
    not going to push too hard on this, but I think you can just use log4j everywhere like
in `QuorumPeerMainTest`


---

Mime
View raw message