From dev-return-66605-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 4 09:23:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 27B59180657 for ; Thu, 4 Jan 2018 09:23:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 17DAE160C2B; Thu, 4 Jan 2018 08:23:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5E32F160C28 for ; Thu, 4 Jan 2018 09:23:05 +0100 (CET) Received: (qmail 51294 invoked by uid 500); 4 Jan 2018 08:23:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 51283 invoked by uid 99); 4 Jan 2018 08:23:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Jan 2018 08:23:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CBA131A0881 for ; Thu, 4 Jan 2018 08:23:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id JFCDMRP3IHJw for ; Thu, 4 Jan 2018 08:23:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3278A5F576 for ; Thu, 4 Jan 2018 08:23:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 791B0E0662 for ; Thu, 4 Jan 2018 08:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 34B7A212F7 for ; Thu, 4 Jan 2018 08:23:00 +0000 (UTC) Date: Thu, 4 Jan 2018 08:23:00 +0000 (UTC) From: "Mohammad Arshad (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (ZOOKEEPER-2960) The dataDir and dataLogDir are used opposingly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310965#comment-16310965 ] Mohammad Arshad edited comment on ZOOKEEPER-2960 at 1/4/18 8:22 AM: -------------------------------------------------------------------- Thanks [~andorm] for submitting your analysis and patch for this issue. I also will have a look on this issue very soon. was (Author: arshad.mohammad): Thanks [~andorm] for reporting this issue, submitting your analysis and patch. I also will have a look on this issue very soon. > The dataDir and dataLogDir are used opposingly > ---------------------------------------------- > > Key: ZOOKEEPER-2960 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2960 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.4.11 > Environment: Not relevant. > Reporter: Dan Milon > Assignee: Andor Molnar > Priority: Critical > > After upgrading from zookeeper 3.4.5, to 3.4.11, without editing {{zoo.cfg}}, the new version of the server tries to use the {{dataDir}} as the {{dataLogDir}}, and the {{dataLogDir}} as the {{dataDir}}. Or at least some parts of the server. > Configuration file has: > {noformat} > $ grep -i data /etc/zookeeper/zoo.cfg > dataLogDir=/var/lib/zookeeper/datalog > dataDir=/var/lib/zookeeper/data > {noformat} > But runtime configuration has: > {noformat} > $ echo conf | nc localhost 2181 | grep -i data > dataDir=/var/lib/zookeeper/datalog/version-2 > dataLogDir=/var/lib/zookeeper/data/version-2 > {noformat} > Also, I got this in the debug logs, so clearly some parts of the server confuse things. > {noformat} > [PurgeTask:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/datalog snapDir:/var/lib/zookeeper/data > [main:FileTxnSnapLog@79] - Opening datadir:/var/lib/zookeeper/data snapDir:/var/lib/zookeeper/datalog > {noformat} > I tried to look in the code for wrong uses of the directories. I only found [ZookeeperServer.java|https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java#L227] is passing the arguments to {{FileTxnSnapLog}} in the wrong order, but the code comment says that this is legacy only for tests, so I assume it isn't the cause for my case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)