From dev-return-66842-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 18 00:59:27 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id E5BF018062C for ; Thu, 18 Jan 2018 00:59:27 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D59A0160C35; Wed, 17 Jan 2018 23:59:27 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2885B160C25 for ; Thu, 18 Jan 2018 00:59:27 +0100 (CET) Received: (qmail 16555 invoked by uid 500); 17 Jan 2018 23:59:26 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 16542 invoked by uid 99); 17 Jan 2018 23:59:26 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Jan 2018 23:59:26 +0000 Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 44DED1A0117 for ; Wed, 17 Jan 2018 23:59:23 +0000 (UTC) Received: by mail-wm0-f54.google.com with SMTP id i186so18456162wmi.4 for ; Wed, 17 Jan 2018 15:59:23 -0800 (PST) X-Gm-Message-State: AKwxyte0mbGwWXAvMkeV6OMbQGzzP8b4rwavM5ktPT2A/B/YROjk9L1Z d80qwK/P6y+UiskfgArorcKM0a+Az4Q+0JRlgEc= X-Google-Smtp-Source: ACJfBosmA/bGRPiVGdGpu+285arKGos8Z5DqCA4tGw6rizoOu2ibz/gUOP152L0UNL75FeH82AubI5YxOzMkIH51Chc= X-Received: by 10.28.54.26 with SMTP id d26mr3271871wma.59.1516233560662; Wed, 17 Jan 2018 15:59:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.186.213 with HTTP; Wed, 17 Jan 2018 15:58:40 -0800 (PST) In-Reply-To: References: <1515191154.2351176.1225810240.45C13A76@webmail.messagingengine.com> From: Patrick Hunt Date: Wed, 17 Jan 2018 15:58:40 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Bug in Zookeeper 3.4.11 release To: DevZooKeeper , "camille@apache.org" Content-Type: multipart/alternative; boundary="001a11436362c7aba5056301a2c8" --001a11436362c7aba5056301a2c8 Content-Type: text/plain; charset="UTF-8" Abe mentioned the following on the jira "Perhaps we should introduce a check of some kind?" I agree with Abe on this - if you're new to ZK in 3.4.11 and you split the directories this commit is going to result in unexpected, and likely very bad, situation. Abe - is there a jira to add this check? I'd like to resolve this and the crc issue and push out a 3.4.12 ASAP. Patrick On Mon, Jan 8, 2018 at 1:44 AM, Andor Molnar wrote: > Thanks Camille. I closed the pull request. > > Andor > > > On Mon, Jan 8, 2018 at 2:32 AM, Camille Fournier > wrote: > > > Yeah, this is bad. I reviewed and merged the PR to get this process > > started. > > > > On Fri, Jan 5, 2018 at 5:25 PM, Abraham Fine wrote: > > > > > I left a comment on the JIRA and I'm not sure what the conventional way > > to > > > proceed would be either. > > > > > > I think we should work to get a release out as quickly as possible with > > > this fix. In addition, I think we may want to add a check on startup > that > > > forces a failure if snapshots/logs are where they shouldn't be. That > way > > we > > > prevent people that are running 3.4.11 from experiencing data loss. > > > > > > Abe > > > > > > On Wed, Jan 3, 2018, at 03:07, Andor Molnar wrote: > > > > Hi all, > > > > > > > > Looks like we've a pretty serious bug in 3.4.11: > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-2960 > > > > > > > > In a nutshell: ZK uses dataDir and dataLogDir parameters in the wrong > > > > order, meaning it tries to access logs in the snapshot folder and > vica > > > > versa. > > > > > > > > Not sure what's the process in such case, but I believe we've to > > > deprecate > > > > 3.4.11 and release a maintenance/hotfix/etc release asap. > > > > > > > > Please advise. > > > > > > > > In the meantime I'm creating a patch to address the issue on > > branch-3.4. > > > > (other branches are not affected) > > > > > > > > Thanks, > > > > Andor > > > > > > --001a11436362c7aba5056301a2c8--