From dev-return-67038-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Jan 25 00:35:03 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 130CE180630 for ; Thu, 25 Jan 2018 00:35:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 02C97160C4F; Wed, 24 Jan 2018 23:35:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 409E0160C3C for ; Thu, 25 Jan 2018 00:35:02 +0100 (CET) Received: (qmail 52007 invoked by uid 500); 24 Jan 2018 23:35:01 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 51986 invoked by uid 99); 24 Jan 2018 23:35:00 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jan 2018 23:35:00 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 75ECCDFC32; Wed, 24 Jan 2018 23:35:00 +0000 (UTC) From: phunt To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep... Content-Type: text/plain Message-Id: <20180124233500.75ECCDFC32@git1-us-west.apache.org> Date: Wed, 24 Jan 2018 23:35:00 +0000 (UTC) Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/443#discussion_r163712079 --- Diff: build.xml --- @@ -1406,50 +1410,53 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant"> + --- End diff -- "I think declaring a "test-coverage-java" target to run Clover does not mean "coverage" == clover. The fact that it currently calls "test-core-java" and "generate-clover-reports" does not mean that we would not allow anybody to add/use other code coverage tools here." Notice how we have cobertura down below in the build.xml file. This is what I mean. "test-coverage-java" just calls clover. If we had created a "test-coverage-java" in the past that called cobertura it seems like that's a statement. It's not a big deal, but hopefully you see what I mean. Renaming to be more clover specific seems reasonable to me. ---