From dev-return-66987-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Tue Jan 23 23:06:18 2018
Return-Path: <dev-return-66987-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@eu.ponee.io
Delivered-To: archive-asf-public@eu.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by mx-eu-01.ponee.io (Postfix) with ESMTP id 2C644180621
	for <archive-asf-public@eu.ponee.io>; Tue, 23 Jan 2018 23:06:18 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 1BE30160C3A; Tue, 23 Jan 2018 22:06:18 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 59235160C24
	for <archive-asf-public@cust-asf.ponee.io>; Tue, 23 Jan 2018 23:06:17 +0100 (CET)
Received: (qmail 20552 invoked by uid 500); 23 Jan 2018 22:06:16 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 20538 invoked by uid 99); 23 Jan 2018 22:06:15 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jan 2018 22:06:15 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 8D9EFE5CE1; Tue, 23 Jan 2018 22:06:15 +0000 (UTC)
From: afine <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-446-zookeeper@git.apache.org>
In-Reply-To: <git-pr-446-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...
Content-Type: text/plain
Message-Id: <20180123220615.8D9EFE5CE1@git1-us-west.apache.org>
Date: Tue, 23 Jan 2018 22:06:15 +0000 (UTC)

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/446#discussion_r163392345
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
             if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
         }
         
    -    public void setRunning(boolean running) {
    +    private void setRunning(boolean running) {
    --- End diff --
    
    +1 to @anmolnar i think we can remote the setter


---