From dev-return-66676-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Mon Jan 8 21:40:33 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id F38B2180607 for ; Mon, 8 Jan 2018 21:40:32 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E3472160C2C; Mon, 8 Jan 2018 20:40:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 35572160C3E for ; Mon, 8 Jan 2018 21:40:32 +0100 (CET) Received: (qmail 77629 invoked by uid 500); 8 Jan 2018 20:40:30 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 76868 invoked by uid 99); 8 Jan 2018 20:40:30 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Jan 2018 20:40:30 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3ADDAE178B; Mon, 8 Jan 2018 20:40:30 +0000 (UTC) From: afine To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #440: ZOOKEEPER-2939 Deal with maxbuffer as it relate... Content-Type: text/plain Message-Id: <20180108204030.3ADDAE178B@git1-us-west.apache.org> Date: Mon, 8 Jan 2018 20:40:30 +0000 (UTC) Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/440#discussion_r160249680 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/ProposalStats.java --- @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.zookeeper.server.quorum; + +import com.codahale.metrics.ExponentiallyDecayingReservoir; +import com.codahale.metrics.Histogram; +import com.codahale.metrics.JmxReporter; +import com.codahale.metrics.MetricRegistry; +import com.codahale.metrics.Reservoir; +import com.codahale.metrics.Snapshot; +import org.apache.zookeeper.jmx.CommonNames; +import org.apache.zookeeper.jmx.MBeanRegistry; + +import static com.codahale.metrics.MetricRegistry.name; + +/** + * Provides real-time metrics on Leader's proposal size. + * The class uses a histogram included in Dropwizard metrics library with ExponentiallyDecayingReservoir. + * It provides stats of proposal sizes from the last 5 minutes with acceptable cpu/memory footprint optimized for streaming data. + */ +public class ProposalStats { + private final Histogram proposalSizes; + + ProposalStats() { + final MetricRegistry metrics = new MetricRegistry(); + Reservoir reservoir = new ExponentiallyDecayingReservoir(); --- End diff -- Perhaps a user configurable SlidingTimeWindowReservoir may be more appropriate? ---