zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup
Date Wed, 24 Jan 2018 07:46:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337084#comment-16337084
] 

ASF GitHub Bot commented on ZOOKEEPER-2967:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/450#discussion_r163395510
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java ---
    @@ -50,6 +50,9 @@
         private static final String SNAP_DIR="snapDir";
         private static final String LOG_DIR="logDir";
         private static final String DB_FORMAT_CONV="dbFormatConversion";
    +
    +    private static final String LOG_FILE_PREFIX = "log";
    --- End diff --
    
    Can we use these field when actually creating the log and snapshot files?


> Add check to validate dataDir and dataLogDir parameters at startup
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2967
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2967
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.11
>            Reporter: Andor Molnar
>            Assignee: Mark Fenes
>            Priority: Major
>              Labels: startup, validation
>             Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> According to  -ZOOKEEPER-2960- we should at a startup check to validate that dataDir
and dataLogDir parameters are set correctly.
> Perhaps we should introduce a check of some kind? If datalogdir is different that datadir
and snapshots exist in datalogdir we throw an exception and quit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message