zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2967) Add check to validate dataDir and dataLogDir parameters at startup
Date Tue, 23 Jan 2018 16:03:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335969#comment-16335969
] 

ASF GitHub Bot commented on ZOOKEEPER-2967:
-------------------------------------------

Github user mfenes commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/450#discussion_r163290119
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/Util.java ---
    @@ -294,5 +297,25 @@ public int compare(File o1, File o2) {
             Collections.sort(filelist, new DataDirFileComparator(prefix, ascending));
             return filelist;
         }
    +
    +    /**
    +     * Returns true if file is a log file.
    +     *
    +     * @param file
    +     * @return
    +     */
    +    public static boolean isLogFile(File file) {
    +        return file.getName().startsWith(LOG_FILE_PREFIX);
    --- End diff --
    
    I agree that it might be safer to check with the dot. I'll add this change.


> Add check to validate dataDir and dataLogDir parameters at startup
> ------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2967
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2967
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.4.11
>            Reporter: Andor Molnar
>            Assignee: Mark Fenes
>            Priority: Major
>              Labels: startup, validation
>             Fix For: 3.5.4, 3.6.0, 3.4.12
>
>
> According to  -ZOOKEEPER-2960- we should at a startup check to validate that dataDir
and dataLogDir parameters are set correctly.
> Perhaps we should introduce a check of some kind? If datalogdir is different that datadir
and snapshots exist in datalogdir we throw an exception and quit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message