zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2955) Enable Clover code coverage report
Date Wed, 24 Jan 2018 23:35:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338434#comment-16338434
] 

ASF GitHub Bot commented on ZOOKEEPER-2955:
-------------------------------------------

Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/443#discussion_r163712079
  
    --- Diff: build.xml ---
    @@ -1406,50 +1410,53 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
     
         <target name="test-core" depends="test-core-java, test-core-cppunit"/>
     
    +    <target name="test-coverage-java">
    --- End diff --
    
    "I think declaring a "test-coverage-java" target to run Clover does not mean "coverage"
== clover. The fact that it currently calls "test-core-java" and "generate-clover-reports"
does not mean that we would not allow anybody to add/use other code coverage tools here."
    
    Notice how we have cobertura down below in the build.xml file. This is what I mean. "test-coverage-java"
just calls clover. If we had created a "test-coverage-java" in the past that called cobertura
it seems like that's a statement. It's not a big deal, but hopefully you see what I mean.
    
    Renaming to be more clover specific seems reasonable to me.


> Enable Clover code coverage report
> ----------------------------------
>
>                 Key: ZOOKEEPER-2955
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2955
>             Project: ZooKeeper
>          Issue Type: Test
>          Components: tests
>    Affects Versions: 3.5.3, 3.4.11
>            Reporter: Mark Fenes
>            Assignee: Mark Fenes
>            Priority: Major
>
> We have limited code coverage support in ZK. Clover for Java was running in the past
but was turned off. 
> Enable Clover code coverage report to make us more confident on the quality, stability
and compatibility of future ZK releases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message