zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
Date Tue, 23 Jan 2018 21:59:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336434#comment-16336434
] 

ASF GitHub Bot commented on ZOOKEEPER-2939:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/440#discussion_r163390292
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/ProposalStats.java ---
    @@ -0,0 +1,70 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server.quorum;
    +
    +import com.codahale.metrics.ExponentiallyDecayingReservoir;
    +import com.codahale.metrics.Histogram;
    +import com.codahale.metrics.JmxReporter;
    +import com.codahale.metrics.MetricRegistry;
    +import com.codahale.metrics.Reservoir;
    +import com.codahale.metrics.Snapshot;
    +import org.apache.zookeeper.jmx.CommonNames;
    +import org.apache.zookeeper.jmx.MBeanRegistry;
    +
    +import static com.codahale.metrics.MetricRegistry.name;
    +
    +/**
    + * Provides real-time metrics on Leader's proposal size.
    + * The class uses a histogram included in Dropwizard metrics library with ExponentiallyDecayingReservoir.
    + * It provides stats of proposal sizes from the last 5 minutes with acceptable cpu/memory
footprint optimized for streaming data.
    + */
    +public class ProposalStats {
    +    private final Histogram proposalSizes;
    +
    +    ProposalStats() {
    +        final MetricRegistry metrics = new MetricRegistry();
    +        Reservoir reservoir = new ExponentiallyDecayingReservoir();
    --- End diff --
    
    From: http://metrics.dropwizard.io/3.1.0/manual/core/#exponentially-decaying-reservoirs
    
    > A histogram with an exponentially decaying reservoir produces quantiles which are
representative of (roughly) the last five minutes of data.
    
    My guess is that we would want more than data representing the last 5 minutes right?


> Deal with maxbuffer as it relates to proposals
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2939
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to proposals.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message