zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-1580) QuorumPeer.setRunning is not used
Date Tue, 09 Jan 2018 06:27:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317821#comment-16317821
] 

ASF GitHub Bot commented on ZOOKEEPER-1580:
-------------------------------------------

GitHub user maoling opened a pull request:

    https://github.com/apache/zookeeper/pull/446

    ZOOKEEPER-1580:QuorumPeer.setRunning is not used

    more details in [JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maoling/zookeeper ZOOKEEPER-1580

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #446
    
----
commit b86ae0e6258b1e9319b75530e4bd917517c380c2
Author: maoling <maoling199210191@...>
Date:   2018-01-09T06:22:04Z

    ZOOKEEPER-1580:QuorumPeer.setRunning is not used

----


> QuorumPeer.setRunning is not used
> ---------------------------------
>
>                 Key: ZOOKEEPER-1580
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1580
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>
> setRunning is a public method and a search did not indicate that it is used anywhere,
not even in tests. In fact, I believe we should not change "running" freely and we should
only do it when calling shutdown. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message