zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfenes <...@git.apache.org>
Subject [GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...
Date Wed, 24 Jan 2018 20:58:03 GMT
Github user mfenes commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/443#discussion_r163675784
  
    --- Diff: build.xml ---
    @@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
         <property name="ivy.javacc.lib" value="${build.dir}/javacc/lib"/>
         <property name="ivy.releaseaudit.lib" value="${build.dir}/releaseaudit/lib"/>
         <property name="ivy.owasp.lib" value="${build.dir}/owasp/lib"/>
    +    <property name="ivy.coverage.lib" value="${test.java.build.dir}/lib"/>
    --- End diff --
    
    Ok. So would changing the location of Clover to ${build.dir}/clover/lib solve this problem?
    
    * Are you ok with the following directory structure:
    build/clover/db for Clover database,
    build/clover/jar for Clover jar,
    build/clover/reports for Clover reports, and
    clover.home=${build.dir}/clover
    
    * Should I change property name "ivy.coverage.lib" to "ivy.clover.lib"?


---

Mime
View raw message