zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #440: ZOOKEEPER-2939 Deal with maxbuffer as it relates to pr...
Date Wed, 24 Jan 2018 11:33:56 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/440
  
    @aberghage Thanks for reviewing this.
    @phunt 
    1. This library has some performance impact for sure, because it calculates more complicated
statistics, while my original solution only exposes last / min / max proposal sizes and doesn't
calculate anything. Not even average.
    
    2. Sure, I'll have to backport it to branch-3.4, it will need some manual work for sure,
but I don't expect it to be the end of the world.
    
    3. Sure, I'd be more than happy if you could merge my previous PR first and later this
one, because that would really mean some progress to be made on my side. Go ahead if you don't
have concerns, I'm getting the build to be green asap. (the small refactoring you mentioned
above is part of that PR too - be aware of that)


---

Mime
View raw message