zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...
Date Wed, 24 Jan 2018 07:45:29 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/450#discussion_r163395848
  
    --- Diff: src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java ---
    @@ -136,13 +136,51 @@ public FileTxnSnapLog(File dataDir, File snapDir) throws IOException
{
                 throw new DatadirException("Cannot write to snap directory " + this.snapDir);
             }
     
    +        // check content of transaction log and snapshot dirs if they are two different
directories
    --- End diff --
    
    Could we add a reference to the discussion that explains why this whole check is needed
in the comments and/or the exception that the user sees?


---

Mime
View raw message