zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #450: ZOOKEEPER-2967: Add check to validate dataDir a...
Date Wed, 24 Jan 2018 07:45:29 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/450#discussion_r163472195
  
    --- Diff: src/java/test/org/apache/zookeeper/server/persistence/FileTxnSnapLogTest.java
---
    @@ -159,4 +159,222 @@ public void onTxnLoaded(TxnHeader hdr, Record rec) {
                 }
             }
         }
    +
    +    @Test
    --- End diff --
    
    there is a lot of code duplication in these tests, i'm wondering if they can be cleaned
up.


---

Mime
View raw message