zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #440: ZOOKEEPER-2939 Deal with maxbuffer as it relate...
Date Tue, 23 Jan 2018 22:01:19 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/440#discussion_r163391127
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZKDatabase.java ---
    @@ -264,19 +262,8 @@ public void addCommittedProposal(Request request) {
                     maxCommittedLog = request.zxid;
                 }
     
    -            ByteArrayOutputStream baos = new ByteArrayOutputStream();
    -            BinaryOutputArchive boa = BinaryOutputArchive.getArchive(baos);
    -            try {
    -                request.getHdr().serialize(boa, "hdr");
    -                if (request.getTxn() != null) {
    -                    request.getTxn().serialize(boa, "txn");
    -                }
    -                baos.close();
    -            } catch (IOException e) {
    -                LOG.error("This really should be impossible", e);
    -            }
    -            QuorumPacket pp = new QuorumPacket(Leader.PROPOSAL, request.zxid,
    -                    baos.toByteArray(), null);
    +            byte[] data = SerializeUtils.serializeRequest(request);
    --- End diff --
    
    Is this really apropos to the stated reason for the PR? If not separating out to another
PR means 1) easier to review this patch, and 2) might be easier to get this committed separately
rather than tying it to another issue.


---

Mime
View raw message