zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...
Date Tue, 23 Jan 2018 21:50:40 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/443#discussion_r163373344
  
    --- Diff: build.xml ---
    @@ -1406,50 +1410,53 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
     
         <target name="test-core" depends="test-core-java, test-core-cppunit"/>
     
    +    <target name="test-coverage-java">
    +        <antcall target="test-core-java">
    +            <param name="run.clover" value="true"/>
    +        </antcall>
    +        <antcall target="generate-clover-reports"/>
    +    </target>
    +
         <!-- ====================================================== -->
         <!-- Run optional third-party tool targets                  -->
         <!-- ====================================================== -->
     
         <!-- clover code coverage -->
    -    <target name="clover" depends="clover.setup, clover.info" 
    -            description="Instrument the Unit tests using Clover.  Requires a Clover license
and CLOVER_HOME environment variable set appropriately.  To use, specify -Drun.clover=true
on the command line."/>
    +    <target name="clover" if="run.clover" depends="ivy-retrieve-test-coverage-java,
clover.check, clover.setup"
    +            description="Instrument the Unit tests using Clover. To use, specify -Drun.clover=true
on the command line."/>
    --- End diff --
    
    we should update this description to show that we have an ant task that can be used instead
of specifying a system property


---

Mime
View raw message