zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...
Date Tue, 23 Jan 2018 20:10:56 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/443#discussion_r163363116
  
    --- Diff: build.xml ---
    @@ -1406,50 +1410,53 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
     
         <target name="test-core" depends="test-core-java, test-core-cppunit"/>
     
    +    <target name="test-coverage-java">
    --- End diff --
    
    Why do we need this given we have a "clover" target?
    
    I'm also hesitant to explicitly code that "coverage" == clover. In the past we've allowed
coverage other than clover to be used.
    
    perhaps "test-coverage-clover-java" instead?


---

Mime
View raw message