zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #443: ZOOKEEPER-2955: Enable Clover code coverage rep...
Date Mon, 22 Jan 2018 20:44:05 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/443#discussion_r163062466
  
    --- Diff: build.xml ---
    @@ -132,21 +169,16 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
         <property name="ant_task_repo_url"
             value="${mvnrepo}${tsk.org}${ant-task.version}/maven-ant-tasks-${ant-task.version}.jar"/>
         <property name="ant_task.jar" location="${ivy.lib}/maven-ant-tasks-${ant-task.version}.jar"/>
    -    
    -    <available property="clover.present"
    -               classname="com.cenqua.clover.CloverInstr"
    -               classpath="${clover.home}/lib/clover.jar"/>
     
    -    <available file="${c.src.dir}/Makefile" property="Makefile.present"/>
    -
    -    <!-- check if clover reports should be generated -->
    -    <condition property="clover.enabled">
    -      <and>
    -        <isset property="run.clover"/>
    -        <isset property="clover.present"/>
    -      </and>
    -    </condition>
    +    <!-- clover property set -->
    +    <property name="clover.home" location="${test.java.build.dir}"/>
    --- End diff --
    
    Similar as comment above - can't we contain this all in it's own subdir?


---

Mime
View raw message