zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #447: [ZOOKEEPER-2926] Fix potential data consistency...
Date Tue, 16 Jan 2018 19:05:09 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/447#discussion_r161855408
  
    --- Diff: src/java/test/org/apache/zookeeper/test/SessionTrackerCheckTest.java ---
    @@ -185,8 +182,8 @@ public void testLeaderSessionTracker() throws Exception {
                     TICK_TIME, expirer.sid, false, testZKSListener());
     
             // Global session
    -        sessionId = 0xdeadbeef;
    -        tracker.addSession(sessionId, CONNECTION_TIMEOUT);
    +        sessionId = 0xdeadbef0;
    --- End diff --
    
    I think this is not changed by intention, might happen when merge patch, I'll get this
fixed.


---

Mime
View raw message