zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #446: ZOOKEEPER-1580:QuorumPeer.setRunning is not use...
Date Tue, 09 Jan 2018 10:17:28 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/446#discussion_r160366222
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
             if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
         }
         
    -    public void setRunning(boolean running) {
    +    private void setRunning(boolean running) {
    --- End diff --
    
    I can't see the point of using a private setter. Set the field directly instead.


---

Mime
View raw message