zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2807) Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
Date Mon, 04 Dec 2017 21:30:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277541#comment-16277541
] 

ASF GitHub Bot commented on ZOOKEEPER-2807:
-------------------------------------------

Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/300
  
    @anmolnar With respect to the code path above, shouldn't that be blocked on `syncWithLeader`?
    
    > Even if you drain the committedRequests, I'm not sure that guarantees that there
are no more that will arrive.
    
    I'm not sure I understand how we don't have this guarantee. My understanding is that `syncWithLeader`
loops until an `UPTODATE` message is received by the follower. Incoming packets from the leader
are read by:
    ```java
                    syncWithLeader(newEpochZxid);                
                    QuorumPacket qp = new QuorumPacket();
                    while (this.isRunning()) {
                        readPacket(qp);
                        processPacket(qp);
                    }
    ```
    
    In addition, my understanding is that requests are only added to `CommitProcessor`'s `committedRequests`
in `processPacket`. What am I missing?


> Flaky test: org.apache.zookeeper.test.WatchEventWhenAutoResetTest.testNodeDataChanged
> -------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2807
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2807
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Abraham Fine
>            Assignee: Abraham Fine
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message