zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Camille Fournier <cami...@apache.org>
Subject Re: Squash/fixup commits
Date Fri, 01 Dec 2017 16:29:44 GMT
You can find details here:


On Fri, Dec 1, 2017 at 1:25 AM, Andor Molnar <andor@cloudera.com> wrote:

> Hi,
> @afine raised this on my latest PR:
> "going forward it would be great if you didn't squash your commits when
> updating your pr in response to comments (I'm guilty of doing this too), i
> think the pr merge script handles that plus it is more difficult to see
> exactly what you changed in response to the comments."
> I was under the impression that keeping one single commit in PRs makes
> commiters' life a lot easier when cherry-picking. Also single commit merges
> keep the git log cleaner on the master branch which is also a plus.
> I won't do fixups going forward to make the reviews easier, just curious
> how does it work behind the scenes?
> Cheers,
> Andor

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message