zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...
Date Thu, 14 Dec 2017 00:30:58 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/430#discussion_r156825263
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1236,7 +1237,7 @@ public void run() {
                                         "Session 0x"
                                                 + Long.toHexString(getSessionId())
                                                 + " for server "
    -                                            + clientCnxnSocket.getRemoteSocketAddress()
    +                                            + serverAddress
                                                 + ", unexpected error"
                                                 + RETRY_CONN_MSG, e);
    --- End diff --
    
    I think it would be good to address the other issue Paul mentioned - no need to dump a
stack if we know this is NoRouteToHostException - why wouldn't we add another elseif to check
for this type?


---

Mime
View raw message