zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From paulmillar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...
Date Wed, 13 Dec 2017 08:55:35 GMT
Github user paulmillar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/430#discussion_r156594864
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1041,6 +1041,8 @@ private void sendPing() {
     
             private InetSocketAddress rwServerAddress = null;
     
    +        private InetSocketAddress addr = null;
    --- End diff --
    
    [non-blocking]
    
    The name could be an ambiguous: is this the address of the local (client) side of the
connection, or the remote (server) side of the connection?  Especially as there is `rwServerAddress`
field member defined immediately above.
    
    Suggest `serverAddress` (or similar)


---

Mime
View raw message