zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper issue #427: [ZOOKEEPER-2338] - set SOCK_CLOEXEC on socket if defin...
Date Tue, 12 Dec 2017 18:16:53 GMT
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/427
  
    For this one I'm fine with the whitespace as it also got into the trunk/3.5 commit.
    
    It's unfortunate that github doesn't have an option to remove whitespace changes from
the diff they show but you can get around this by diffing the commit locally. (which is what
I typically do)
    
    Agree with @mfenes 's comment - even though this is a backport it's still nice to have.

    
    Thanks @fr0stbyte !


---

Mime
View raw message