zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Date Fri, 01 Dec 2017 23:41:24 GMT
Github user phunt commented on the issue:

    https://github.com/apache/zookeeper/pull/420
  
    > I don't think most of these tests make any assertions that could be impacted by the
snapCount.
    
    This is an ambiguous statement to me. You do see that some of the tests are impacted though,
right? 
    
    e.g.:
            // Verify that we have at least NUM_MESSAGES / SNAPCOUNT txnlog
            etc....
    
    I am I missing something? In testLoadFailure we need at least two log files or otw the
test will fail. Not setting the snapcount appropriately (small relative to num messages) would
be an issue, no?


---

Mime
View raw message