zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From abel-von <...@git.apache.org>
Subject [GitHub] zookeeper pull request #423: ZOOKEEPER-2949: using hostname and port to crea...
Date Fri, 01 Dec 2017 07:12:49 GMT
Github user abel-von commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/423#discussion_r154279983
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
    @@ -340,13 +340,24 @@ public static Packet getInstance() {
                 return instance;
             }
         }
    +
         /**
          * ZKClientPipelineFactory is the netty pipeline factory for this netty
          * connection implementation.
          */
         private class ZKClientPipelineFactory implements ChannelPipelineFactory {
             private SSLContext sslContext = null;
             private SSLEngine sslEngine = null;
    +        private String host;
    +        private int port;
    +
    +        public ZKClientPipelineFactory() {
    --- End diff --
    
    Maybe not,but  it's just a good thing to keep the default constructor when I define
a constructor with parameters. 


---

Mime
View raw message