Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
Date: Tue, 7 Nov 2017 01:30:00 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: dev@zookeeper.apache.org
Message-ID: <JIRA.13116336.1509959873000.164961.1510018200562@Atlassian.JIRA>
In-Reply-To: <JIRA.13116336.1509959873000@Atlassian.JIRA>
References: <JIRA.13116336.1509959873000@Atlassian.JIRA> <JIRA.13116336.1509959873791@jira-lw-us.apache.org>
Subject: [jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about
 purging task
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Nov 2017 01:30:05 -0000


    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241301#comment-16241301 ] 

Hadoop QA commented on ZOOKEEPER-2932:
--------------------------------------

-1 overall.  GitHub Pull Request  Build
      

    +1 @author.  The patch does not contain any @author tags.

    +0 tests included.  The patch appears to be a documentation patch that doesn't require tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1163//console

This message is automatically generated.

> Performance enhancement about purging task
> ------------------------------------------
>
>                 Key: ZOOKEEPER-2932
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to be retained base on the given zxid when purging task is running. The current implementation of this method is trivial to understand, and iterate the log files twice to achieve its purchase. It could be improved from both performance and readability.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)