Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A60D0200D5A for ; Thu, 30 Nov 2017 06:28:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9B4D2160C16; Thu, 30 Nov 2017 05:28:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D868E160C04 for ; Thu, 30 Nov 2017 06:28:56 +0100 (CET) Received: (qmail 65429 invoked by uid 500); 30 Nov 2017 05:28:55 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 65417 invoked by uid 99); 30 Nov 2017 05:28:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Nov 2017 05:28:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 7A692F17F3; Thu, 30 Nov 2017 05:28:54 +0000 (UTC) From: afine To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java Content-Type: text/plain Message-Id: <20171130052854.7A692F17F3@git1-us-west.apache.org> Date: Thu, 30 Nov 2017 05:28:54 +0000 (UTC) archived-at: Thu, 30 Nov 2017 05:28:57 -0000 Github user afine commented on the issue: https://github.com/apache/zookeeper/pull/420 @phunt I think it's fine to always modify the `snapCount`. My concern was primarily modifying it once the zookeeper server was running created nondeterministic behavior. In addition, I don't think most of these tests make any assertions that could be impacted by the `snapCount`. So I think the current iteration of the tests is fine. Also, +1 on removing the lines instead of commenting them out and using a smaller snapCount. Otherwise lgtm. ---