Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1B034200D4A for ; Tue, 28 Nov 2017 20:10:57 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 19673160C07; Tue, 28 Nov 2017 19:10:57 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 56DFA160BE7 for ; Tue, 28 Nov 2017 20:10:56 +0100 (CET) Received: (qmail 60984 invoked by uid 500); 28 Nov 2017 19:10:55 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 60972 invoked by uid 99); 28 Nov 2017 19:10:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Nov 2017 19:10:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 15317E02F5; Tue, 28 Nov 2017 19:10:55 +0000 (UTC) From: phunt To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe... Content-Type: text/plain Message-Id: <20171128191055.15317E02F5@git1-us-west.apache.org> Date: Tue, 28 Nov 2017 19:10:55 +0000 (UTC) archived-at: Tue, 28 Nov 2017 19:10:57 -0000 Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/420#discussion_r153592393 --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java --- @@ -413,20 +240,10 @@ public void testRestore() throws Exception { */ @Test public void testRestoreWithTransactionErrors() throws Exception { - final String hostPort = HOST + PortAssignment.unique(); - // setup a single server cluster - File tmpDir = ClientBase.createTmpDir(); - ClientBase.setupTestEnv(); - ZooKeeperServer zks = new ZooKeeperServer(tmpDir, tmpDir, 3000); SyncRequestProcessor.setSnapCount(10000); --- End diff -- same... ---