Return-Path: <dev-return-65868-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 277FA200D4B
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 27 Nov 2017 11:56:10 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 25EF3160C13; Mon, 27 Nov 2017 10:56:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 63C36160C02
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 27 Nov 2017 11:56:09 +0100 (CET)
Received: (qmail 96751 invoked by uid 500); 27 Nov 2017 10:56:08 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 96740 invoked by uid 99); 27 Nov 2017 10:56:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Nov 2017 10:56:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1B183DF9C5; Mon, 27 Nov 2017 10:56:08 +0000 (UTC)
From: rakeshadr <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-417-zookeeper@git.apache.org>
In-Reply-To: <git-pr-417-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #417: ZOOKEEPER-2935: [QP MutualAuth]: Port ZOOKEEPER...
Content-Type: text/plain
Message-Id: <20171127105608.1B183DF9C5@git1-us-west.apache.org>
Date: Mon, 27 Nov 2017 10:56:08 +0000 (UTC)
archived-at: Mon, 27 Nov 2017 10:56:10 -0000

Github user rakeshadr commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/417#discussion_r153161187
  
    --- Diff: ivy.xml ---
    @@ -90,6 +90,69 @@
         <dependency org="org.owasp" name="dependency-check-ant"
                     rev="${dependency-check-ant.version}" conf="owasp->default"/>
     
    +    <dependency org="commons-io" name="commons-io"
    +                rev="${commons-io.version}" conf="test->default"/>
    +
    +      <dependency org="org.apache.kerby" name="kerby-config" rev="${kerby.version}" conf="test->default">
    +          <exclude org="org.slf4j" module="slf4j-api"/>
    --- End diff --
    
    Good work! Thanks @afine for your efforts. 
    Apart from @phunt comment, I've below observation.
    
    Should we need to exclude 'slf4j-api' and 'slf4j-log4j12' from all the kerb dependency, which is missing in branch-3.5. If needed then could you please raise a minor imprv task to correct in branch-3.5 and push it in together, that would syncup the code between branches.


---