Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@zookeeper.apache.org
From: afine <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-419-zookeeper@git.apache.org>
In-Reply-To: <git-pr-419-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #419: ZOOKEEPER-2849: Exponential back-off retry for ...
Content-Type: text/plain
Message-Id: <20171116225156.0F370DFC2E@git1-us-west.apache.org>
Date: Thu, 16 Nov 2017 22:51:54 +0000 (UTC)
archived-at: Thu, 16 Nov 2017 22:51:59 -0000

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/419#discussion_r151532589
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java ---
    @@ -946,7 +946,8 @@ protected Election createElectionAlgorithm(int electionAlgorithm){
                     le = new AuthFastLeaderElection(this, true);
                     break;
                 case 3:
    -                qcm = new QuorumCnxManager(this);
    +                qcm = new QuorumCnxManager(this,
    +                    ExponentialBackoffStrategy.builder().build());
    --- End diff --
    
    Perhaps we should find a way to make this pluggable? Perhaps we can read which backoff strategy to use from a java system property?


---