Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8F470200D4C for ; Thu, 16 Nov 2017 01:01:25 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8DE2B160BF6; Thu, 16 Nov 2017 00:01:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id CBDBE160BF4 for ; Thu, 16 Nov 2017 01:01:24 +0100 (CET) Received: (qmail 42074 invoked by uid 500); 16 Nov 2017 00:01:23 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 42054 invoked by uid 99); 16 Nov 2017 00:01:23 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Nov 2017 00:01:23 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 853C3DFAB4; Thu, 16 Nov 2017 00:01:23 +0000 (UTC) From: phunt To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b... Content-Type: text/plain Message-Id: <20171116000123.853C3DFAB4@git1-us-west.apache.org> Date: Thu, 16 Nov 2017 00:01:23 +0000 (UTC) archived-at: Thu, 16 Nov 2017 00:01:25 -0000 Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/415 I didn't look at this in much depth yet but one obvious things struck me - you are missing the reset capability. See how we handle latency tracking in the beans. We try to keep jmx, 4lw and jetty interfaces (new in 3.5) in lock step wrt the metrics they provide. What do you think, do you want to try to include that in this patch or create separate JIRA(s) to track/address? ---