Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4F02D200D37 for ; Thu, 9 Nov 2017 20:25:12 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4D6CC160BEF; Thu, 9 Nov 2017 19:25:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8BECD1609C8 for ; Thu, 9 Nov 2017 20:25:11 +0100 (CET) Received: (qmail 58476 invoked by uid 500); 9 Nov 2017 19:25:10 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 58465 invoked by uid 99); 9 Nov 2017 19:25:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Nov 2017 19:25:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 81C6ADFBCA; Thu, 9 Nov 2017 19:25:09 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #415: ZOOKEEPER-2939: Added last/min/max proposal size JMX b... Content-Type: text/plain Message-Id: <20171109192509.81C6ADFBCA@git1-us-west.apache.org> Date: Thu, 9 Nov 2017 19:25:09 +0000 (UTC) archived-at: Thu, 09 Nov 2017 19:25:12 -0000 Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/415 @afine Take a look at please the latest commit, I've added verification of the byte array itself to serializeRequest() unit test. I'm not 100% sure it's needed, but it might makes sense this way. ---