zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2939) Deal with maxbuffer as it relates to proposals
Date Mon, 20 Nov 2017 22:30:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259958#comment-16259958
] 

ASF GitHub Bot commented on ZOOKEEPER-2939:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r152110769
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/StatResetCommandTest.java ---
    @@ -0,0 +1,112 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server.quorum;
    +
    +import org.apache.zookeeper.server.ServerCnxn;
    +import org.apache.zookeeper.server.ServerStats;
    +import org.apache.zookeeper.server.ZooKeeperServer;
    +import org.apache.zookeeper.server.command.StatResetCommand;
    +import org.junit.Before;
    +import org.junit.Test;
    +
    +import java.io.PrintWriter;
    +import java.io.StringWriter;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.mockito.Mockito.mock;
    +import static org.mockito.Mockito.times;
    +import static org.mockito.Mockito.verify;
    +import static org.mockito.Mockito.when;
    +
    +public class StatResetCommandTest {
    +    private static final String ZK_NOT_SERVING = "This ZooKeeper instance is not currently
serving requests\n";
    --- End diff --
    
    nit: maybe we should make the version of this in AbstractFourLetterCommand visible to
this class for the purpose of testing.


> Deal with maxbuffer as it relates to proposals
> ----------------------------------------------
>
>                 Key: ZOOKEEPER-2939
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2939
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>             Fix For: 3.5.4, 3.6.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message