zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andor Molnar (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ZOOKEEPER-2934) c versions of election and queue recipes do not compile
Date Tue, 07 Nov 2017 11:23:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241843#comment-16241843
] 

Andor Molnar edited comment on ZOOKEEPER-2934 at 11/7/17 11:22 AM:
-------------------------------------------------------------------

I've taken a look at other usages of LOG_DEBUG macro and it looks slightly different in the
C client library.

{code}
src/c/src/zookeeper.c:    LOG_DEBUG(LOGCALLBACK(zh), "Sending request xid=%#x for path [%s]
to %s",h.xid,path,
{code}

wheres in the recipe code:

{code}
src/recipes/queue/src/c/src/zoo_queue.c:        LOG_DEBUG(("Error! Called await twice."));
{code}

I suspect that the macro has been changed recently and the recipe hasn't been updated. 
I'll take a closer look how to fix it later today.


was (Author: andorm):
I've taken a look at other usages of LOG_DEBUG macro and it looks slightly different in the
C client library.

{code:c}
src/c/src/zookeeper.c:    LOG_DEBUG(LOGCALLBACK(zh), "Sending request xid=%#x for path [%s]
to %s",h.xid,path,
{code}

wheres in the recipe code:

{code:c}
src/recipes/queue/src/c/src/zoo_queue.c:        LOG_DEBUG(("Error! Called await twice."));
{code}

I suspect that the macro has been changed recently and the recipe hasn't been updated. 
I'll take a closer look how to fix it later today.

> c versions of election and queue recipes do not compile
> -------------------------------------------------------
>
>                 Key: ZOOKEEPER-2934
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2934
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: recipes
>    Affects Versions: 3.4.10, 3.5.3
>            Reporter: Abraham Fine
>
> I see errors like: 
> {code}
> /var/zookeeper/src/recipes/queue/src/c/../../../../../src/c/include/zookeeper_log.h:39:74:
error: expected expression before ')' token
>      log_message(_cb, ZOO_LOG_LEVEL_DEBUG, __LINE__, __func__, __VA_ARGS__)
>                                                                           ^
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message