zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time
Date Thu, 09 Nov 2017 00:19:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244982#comment-16244982
] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r149832324
  
    --- Diff: src/java/main/org/apache/zookeeper/server/ZooKeeperServerBean.java ---
    @@ -167,4 +167,9 @@ public String getSecureClientAddress() {
         public long getTxnLogElapsedSyncTime() {
             return zks.getTxnLogElapsedSyncTime();
         }
    +
    +    @Override
    +    public int getJuteMaxBufferSize() {
    +        return Integer.getInteger("jute.maxbuffer", 0xfffff);
    --- End diff --
    
    I think the magic number 0xfffff is defined elsewhere in the code, it would be great to
only have it in one place.


> Ability to monitor the jute.maxBuffer usage in real-time
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-2933
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>              Labels: buffer, buffer-length
>             Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader generates a
proposal that doesn't fit into Follower's Jute buffer causing the quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current jute.maxbuffer
setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of the latest/min/max
proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message