zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2933) Ability to monitor the jute.maxBuffer usage in real-time
Date Thu, 09 Nov 2017 00:19:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244978#comment-16244978
] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r149830970
  
    --- Diff: src/java/test/org/apache/zookeeper/server/quorum/LeaderStatsTest.java ---
    @@ -0,0 +1,39 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server.quorum;
    +
    +import org.junit.Test;
    +
    +import static org.junit.Assert.assertEquals;
    +
    +public class LeaderStatsTest {
    +    @Test
    +    public void testSetProposalSize_SetMinMax() {
    +        LeaderStats stats = new LeaderStats();
    --- End diff --
    
    Maybe we should check what the min and max are before a proposal is received to make sure
we set that behavior in stone.


> Ability to monitor the jute.maxBuffer usage in real-time
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-2933
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>              Labels: buffer, buffer-length
>             Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader generates a
proposal that doesn't fit into Follower's Jute buffer causing the quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current jute.maxbuffer
setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of the latest/min/max
proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message