zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2932) Performance enhancement about purging task
Date Mon, 06 Nov 2017 13:53:01 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240323#comment-16240323
] 

ASF GitHub Bot commented on ZOOKEEPER-2932:
-------------------------------------------

GitHub user OuYangLiang opened a pull request:

    https://github.com/apache/zookeeper/pull/414

    ZOOKEEPER-2932 Performance enhancement about purging task.

    The method FileTxnLog.getLogFiles is used to find out the target log files to be retained
base on the given zxid when purging task is running. The current implementation of this method
is trivial to understand, and iterate the log files twice to achieve its purchase. It could
be improved from both performance and readability.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/OuYangLiang/zookeeper master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/414.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #414
    
----
commit 598841212f6e197f2a5577a84432a6bd7e886201
Author: ouyangliang <ouyanggod@gmail.com>
Date:   2017-11-06T13:48:43Z

    ZOOKEEPER-2932 Performance enhancement about purging task.

----


> Performance enhancement about purging task
> ------------------------------------------
>
>                 Key: ZOOKEEPER-2932
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: OuYang Liang
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The method FileTxnLog.getLogFiles is used to find out the target log files to be retained
base on the given zxid when purging task is running. The current implementation of this method
is trivial to understand, and iterate the log files twice to achieve its purchase. It could
be improved from both performance and readability.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message