zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2901) Session ID that is negative causes mis-calculation of Ephemeral Type
Date Fri, 03 Nov 2017 14:28:00 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237656#comment-16237656
] 

ASF GitHub Bot commented on ZOOKEEPER-2901:
-------------------------------------------

Github user Randgalt commented on the issue:

    https://github.com/apache/zookeeper/pull/377
  
    > I used the sample zoo.cfg file as my config and started via bin/zkServer.sh - however
I can still create a ttl based node even though "ttlNodesEnabled=false" in the zoo.cfg. I
recommend you add a test for this.
    
    @phunt I imagine the server started in Standalone mode. Please verify. When the server
starts in Standalone mode it ignores most of zoo.cfg. Also in Standalone mode there is no
Server ID so it's a non issue. If you add `server.X` and `standaloneEnabled=false` to zoo.cfg
then the ttlNodesEnabled has effect. Make sense? Does this need to be documented?


> Session ID that is negative causes mis-calculation of Ephemeral Type
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2901
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.5.3
>         Environment: Running 3.5.3-beta in Docker container
>            Reporter: Mark Johnson
>            Assignee: Jordan Zimmerman
>            Priority: Blocker
>
> In the code that determines the EphemeralType it is looking at the owner (which is the
client ID or connection ID):
> EphemeralType.java:
>    public static EphemeralType get(long ephemeralOwner) {
>        if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) {
>            return CONTAINER;
>        }
>        if (ephemeralOwner < 0) {
>            return TTL;
>        }
>        return (ephemeralOwner == 0) ? VOID : NORMAL;
>    }
> However my connection ID is:
> header.getClientId(): -720548323429908480
> This causes the code to think this is a TTL Ephemeral node instead of a
> NORMAL Ephemeral node.
> This also explains why this is random - if my client ID is non-negative
> then the node gets added correctly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message