zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ZOOKEEPER-2795) Change log level for "ZKShutdownHandler is not registered" error message
Date Fri, 17 Nov 2017 17:50:08 GMT

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257299#comment-16257299

ASF GitHub Bot commented on ZOOKEEPER-2795:

Github user phunt commented on the issue:

    iiuc that change comes from https://issues.apache.org/jira/browse/ZOOKEEPER-2247 and the
concern is that we'd silently be broken without this log message. While the code change is
trivial I'm concerned about the operational impact. Did you look into what happens in this
situation? Without this log message how would the operator diagnose this problem? Is there
a better way to do this? e.g. if it's truly an "ERROR" shouldn't we shut down the server?
We'd obviously need to consider the b/w compat issues here as well such as the use in Kafka
as recently pointed out.

> Change log level for "ZKShutdownHandler is not registered" error message
> ------------------------------------------------------------------------
>                 Key: ZOOKEEPER-2795
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2795
>             Project: ZooKeeper
>          Issue Type: Wish
>    Affects Versions: 3.4.10, 3.5.3, 3.6.0
>            Reporter: Andy Chambers
>            Assignee: Abraham Fine
>            Priority: Trivial
> We have an integration test suite that starts up an embedded version of zookeeper as
part of a suite of services.
> However because it doesn't register a shutdown handler, we get lots of warnings that
look like this
> 17-05-30 15:04:56 achambers.local ERROR [org.apache.zookeeper.server.ZooKeeperServer:472]
- ZKShutdownHandler is not registered, so ZooKeeper server won't take any action on ERROR
or SHUTDOWN server state changes
> My java is a bit rusty but I think I can't create one of these shutdown handlers from
outside the "org.apache.zookeeper.server" package because the constructor has not been marked
"public". Would it be possible to do so?

This message was sent by Atlassian JIRA

View raw message