zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #425: Add keys for the Zxid from the stat command
Date Thu, 30 Nov 2017 22:33:22 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/425#discussion_r154221468
  
    --- Diff: src/contrib/monitoring/check_zookeeper.py ---
    @@ -251,6 +256,13 @@ def _parse_stat(self, data):
                     result['zk_znode_count'] = int(m.group(1))
                     continue
     
    +            m = re.match('Zxid: (0x[0-9a-fA-F]+)', line)
    +            if m is not None:
    +                result['zk_zxid']         = int(m.group(1), 16) # convert from hex
    --- End diff --
    
    Since the zxid is being split up below, it may be valuable to leave this in hex.


---

Mime
View raw message