zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Date Thu, 30 Nov 2017 05:28:54 GMT
Github user afine commented on the issue:

    https://github.com/apache/zookeeper/pull/420
  
    @phunt I think it's fine to always modify the `snapCount`. My concern was primarily modifying
it once the zookeeper server was running created nondeterministic behavior.
    
    In addition, I don't think most of these tests make any assertions that could be impacted
by the `snapCount`. So I think the current iteration of the tests is fine.
    
    Also, +1 on removing the lines instead of commenting them out and using a smaller snapCount.
    
    Otherwise lgtm.


---

Mime
View raw message