zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTest.java
Date Wed, 29 Nov 2017 12:44:11 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/420
  
    @phunt @afine thanks for the detail comments.
    I think @afine made a good point, I've removed setting the SnapCount explicitly in each
test, leaving only a common setting in the setUp method. Only those 2 tests really care about
the setting and with a little modification, they can share the same setting.


---

Mime
View raw message