zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...
Date Tue, 28 Nov 2017 19:10:32 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/420#discussion_r153592781
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ---
    @@ -449,50 +267,25 @@ public void testRestoreWithTransactionErrors() throws Exception
{
             // Force snapshot and restore
             zks.takeSnapshot();
             zks.shutdown();
    -        f.shutdown();
    +        stopServer();
     
             zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
             SyncRequestProcessor.setSnapCount(10000);
    -        f = ServerCnxnFactory.createFactory(PORT, -1);
    -        f.startup(zks);
    -        Assert.assertTrue("waiting for server being up ", ClientBase
    -                .waitForServerUp(hostPort, CONNECTION_TIMEOUT));
    -
    -        f.shutdown();
    -        zks.shutdown();
    +        startServer();
         }
     
         /**
          * Verify snap/log dir create with/without autocreate enabled.
          */
         @Test
         public void testDatadirAutocreate() throws Exception {
    -        ClientBase.setupTestEnv();
    --- End diff --
    
    not sure if it matters here and in the following test method but the snapcount is different
after the current patch.


---

Mime
View raw message