zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From phunt <...@git.apache.org>
Subject [GitHub] zookeeper pull request #420: ZOOKEEPER-2924. Refactor tests of LoadFromLogTe...
Date Tue, 28 Nov 2017 19:10:32 GMT
Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/420#discussion_r153592257
  
    --- Diff: src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java ---
    @@ -370,20 +202,17 @@ public void testRestore() throws Exception {
             // Force snapshot and restore
             zks.takeSnapshot();
             zks.shutdown();
    -        f.shutdown();
    +        stopServer();
     
    -        zks = new ZooKeeperServer(tmpDir, tmpDir, 3000);
             SyncRequestProcessor.setSnapCount(10000);
    --- End diff --
    
    I believe this is ok as the server is restarted (but you might want to verify).


---

Mime
View raw message