zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From afine <...@git.apache.org>
Subject [GitHub] zookeeper pull request #415: ZOOKEEPER-2939: Added last/min/max proposal siz...
Date Tue, 21 Nov 2017 17:37:03 GMT
Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r152349015
  
    --- Diff: build.xml ---
    @@ -1817,7 +1817,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
                  description="Create eclipse project files">
            <ivy:resolve useOrigin="true" conf="test"/>
            <ivy:cachepath pathid="default.path.id" conf="default" />
    -       <ivy:cachepath pathid="junit.path.id" conf="test" transitive="false"/>
    +       <ivy:cachepath pathid="junit.path.id" conf="test" transitive="true"/>
    --- End diff --
    
    nit: we can just remove the transitive property to be consistent


---

Mime
View raw message