zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #415: ZOOKEEPER-2933: Added last/min/max proposal siz...
Date Thu, 09 Nov 2017 12:18:59 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r149946142
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -984,8 +990,6 @@ public void commitAndActivate(long zxid, long designatedLeader) {
     
         /**
          * Create an inform packet and send it to all observers.
    -     * @param zxid
    -     * @param proposal
    --- End diff --
    
    Intellij keep notifying me about these comments not referring to valid parameters in the
method definition anymore. I thought it'd be nice to do some cleanup together with the patch.


---

Mime
View raw message